From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10489 invoked by alias); 6 Apr 2007 23:36:12 -0000 Received: (qmail 10479 invoked by uid 22791); 6 Apr 2007 23:36:10 -0000 X-Spam-Check-By: sourceware.org Received: from palrel13.hp.com (HELO palrel13.hp.com) (156.153.255.238) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 07 Apr 2007 00:36:09 +0100 Received: from smtp2.cup.hp.com (hpda.cup.hp.com [15.4.32.118]) by palrel13.hp.com (Postfix) with ESMTP id 449B137238; Fri, 6 Apr 2007 16:36:07 -0700 (PDT) Received: from hpsje.cup.hp.com (hpsje.cup.hp.com [16.89.92.85]) by smtp2.cup.hp.com (Postfix) with ESMTP id ED57330C0B8; Fri, 6 Apr 2007 23:29:10 +0000 (UTC) Received: (from sje@localhost) by hpsje.cup.hp.com (8.9.3 (PHNE_29774)/8.9.3) id QAA17806; Fri, 6 Apr 2007 16:36:06 -0700 (PDT) Date: Fri, 06 Apr 2007 23:36:00 -0000 From: Steve Ellcey Message-Id: <200704062336.QAA17806@hpsje.cup.hp.com> To: mark.kettenis@xs4all.nl Cc: gdb-patches@sourceware.org Subject: Re: Patch for isdigit/isalpha/etc. macro arguments In-Reply-To: <200704062303.l36N3AgL014922@brahms.sibelius.xs4all.nl> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00037.txt.bz2 > Sorry, you obviously spent some serious amount of time fixing this, > but I think this is just gross. It also would just hide the bug > mentioned above. I guess we should use -liberty's "safe-ctype.h" > instead. Hm, this seems to lead to some new problems. safe-ctype.h defines ISALNUM, ISALPHA, ISDIGIT, etc. (uppercase) and if I start including "safe-ctype.h" instead of , then I collide with readline/chardefs.h in some files (like cli/cli-dump.c) because that file includes readline/readline.h which includes readline/chardefs.h which has its own definitions of ISALNUM, ISALPHA, ISDIGIT, etc. What to do? My best guess would be to have readline/chardefs.h not define these macros if they are already defined. But now we are reaching outside the gdb subdir. Steve Ellcey sje@cup.hp.com