From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4498 invoked by alias); 6 Apr 2007 23:17:41 -0000 Received: (qmail 4481 invoked by uid 22791); 6 Apr 2007 23:17:39 -0000 X-Spam-Check-By: sourceware.org Received: from palrel10.hp.com (HELO palrel10.hp.com) (156.153.255.245) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 07 Apr 2007 00:17:35 +0100 Received: from smtp2.cup.hp.com (unknown [15.4.32.118]) by palrel10.hp.com (Postfix) with ESMTP id 1BE9137008; Fri, 6 Apr 2007 16:17:34 -0700 (PDT) Received: from hpsje.cup.hp.com (hpsje.cup.hp.com [16.89.92.85]) by smtp2.cup.hp.com (Postfix) with ESMTP id D305130BD42; Fri, 6 Apr 2007 23:10:37 +0000 (UTC) Received: (from sje@localhost) by hpsje.cup.hp.com (8.9.3 (PHNE_29774)/8.9.3) id QAA17582; Fri, 6 Apr 2007 16:17:33 -0700 (PDT) Date: Fri, 06 Apr 2007 23:17:00 -0000 From: Steve Ellcey Message-Id: <200704062317.QAA17582@hpsje.cup.hp.com> To: mark.kettenis@xs4all.nl Cc: gdb-patches@sourceware.org Subject: Re: Patch for isdigit/isalpha/etc. macro arguments In-Reply-To: <200704062303.l36N3AgL014922@brahms.sibelius.xs4all.nl> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00036.txt.bz2 > Sorry, you obviously spent some serious amount of time fixing this, > but I think this is just gross. It also would just hide the bug > mentioned above. I guess we should use -liberty's "safe-ctype.h" > instead. It didn't take that long, I kept going because I kept thinking I had found the "last one". I didn't realise how many of them there were until I finally had a build working. Using -liberty and safe-ctype.h seems reasonable but it looks like we still need to change all the files though in order to switch them from isdigit, etc. to ISDIGIT, etc. is that correct? Steve Ellcey sje@cup.hp.com