From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-48278-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17762 invoked by alias); 6 Apr 2007 08:24:45 -0000
Received: (qmail 17752 invoked by uid 22791); 6 Apr 2007 08:24:43 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 06 Apr 2007 09:24:39 +0100
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.0/8.14.0) with ESMTP id l368O9P0017618; 	Fri, 6 Apr 2007 10:24:09 +0200 (CEST)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.0/8.14.0/Submit) id l368O8pv013695; 	Fri, 6 Apr 2007 10:24:08 +0200 (CEST)
Date: Fri, 06 Apr 2007 08:24:00 -0000
Message-Id: <200704060824.l368O8pv013695@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: ghost@cs.msu.su
CC: gdb-patches@sources.redhat.com
In-reply-to: <ev4o2p$v2n$1@sea.gmane.org> (message from Vladimir Prus on Fri, 	06 Apr 2007 10:06:24 +0400)
Subject: Re: "target remote | " stderr -- try2
References: <200703251735.13369.vladimir@codesourcery.com> <20070329180627.GD28418@caradoc.them.org> <ev4o2p$v2n$1@sea.gmane.org>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-04/txt/msg00026.txt.bz2

> From: Vladimir Prus <ghost@cs.msu.su>
> Date:  Fri, 06 Apr 2007 10:06:24 +0400
> 
> Daniel Jacobowitz wrote:
> 
> > On Sun, Mar 25, 2007 at 04:35:13PM +0300, Vladimir Prus wrote:
> >> 
> >> This is a revision of my earlier patch to make
> >> stderr output from program run with
> >> 
> >>    target remote | some_program
> >> 
> >> to be routed through gdb_stderr, so that MI
> >> frontend sees that output.
> >> 
> >> The original patch is at:
> >> 
> >> http://thread.gmane.org/gmane.comp.gdb.patches/32540
> >> 
> >> and this version differs by not having any #ifdef WIN32 inside
> >> ser-base.c, but instead using new method in 'struct serial_ops',
> >> that is initialized in ser-mingw.c.
> >> 
> >> OK?
> > 
> > This version is OK.  Thanks!
> 
> Doh! It turns out I've attached a patch that won't even compile.
> Although the difference to the real patch is trivial, for avoidance
> of doubt I attach the "right" patch and the delta to the previous
> one. Is this version OK?

I like this version a lot better than the one with #ifdef WIN32.
Thanks Volodya, for taking the trouble to clean things up.

Mark