From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-48242-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18464 invoked by alias); 31 Mar 2007 09:10:10 -0000
Received: (qmail 18448 invoked by uid 22791); 31 Mar 2007 09:10:09 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 31 Mar 2007 10:10:05 +0100
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.0/8.14.0) with ESMTP id l2V9A1Fo022464; 	Sat, 31 Mar 2007 11:10:01 +0200 (CEST)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.0/8.14.0/Submit) id l2V9A0dA019101; 	Sat, 31 Mar 2007 11:10:00 +0200 (CEST)
Date: Sat, 31 Mar 2007 09:10:00 -0000
Message-Id: <200703310910.l2V9A0dA019101@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: schwab@suse.de
CC: gdb-patches@sourceware.org
In-reply-to: <jehcs45lfn.fsf@sykes.suse.de> (message from Andreas Schwab on 	Thu, 29 Mar 2007 13:38:36 +0200)
Subject: Re: Signed vs. unsigned adresses in solib-svr4
References: <je8xdi33ar.fsf@sykes.suse.de> 	<20070327192144.GK28164@caradoc.them.org> 	<je4po630c8.fsf@sykes.suse.de> 	<20070327203551.GA22750@caradoc.them.org> <jehcs45lfn.fsf@sykes.suse.de>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-03/txt/msg00373.txt.bz2

> From: Andreas Schwab <schwab@suse.de>
> Date: Thu, 29 Mar 2007 13:38:36 +0200
> 
> Daniel Jacobowitz <drow@false.org> writes:
> 
> > On Tue, Mar 27, 2007 at 10:20:23PM +0200, Andreas Schwab wrote:
> >> > - since I know that the assumption is wrong for MIPS.  Isn't there an
> >> > extract_address or something like that which would be suitable?
> >> 
> >> There is extract_typed_address, but I don't know how to construct the
> >> struct type that it needs.
> >
> > Probably builtin_type_void_data_ptr is all you need.
> 
> How about this then?  Regtestest on
> {i386,ia64,ppc,ppc64,s390,s390x,x86_64}-linux.

I like this.

> 
> Andreas.
> 
> 2007-03-29  Andreas Schwab  <schwab@suse.de>
> 
> 	* solib-svr4.h (struct link_map_offsets): Remove l_addr_size,
> 	l_ld_size, l_next_size, l_prev_size, l_name_size.
> 
> 	* solib-svr4.c (LM_ADDR_FROM_LINK_MAP): Use extract_typed_address
> 	to extract addresses from link map.
> 	(LM_DYNAMIC_FROM_LINK_MAP): Likewise.
> 	(LM_NEXT): Likewise.
> 	(LM_NAME): Likewise.
> 	(IGNORE_FIRST_LINK_MAP_ENTRY): Likewise.
> 	(elf_locate_base): Likewise.
> 	(open_symbol_file_object): Likewise.
> 	(svr4_fetch_objfile_link_map): Likewise.
> 	(SOLIB_EXTRACT_ADDRESS): Remove unused macro.
> 	(HAS_LM_DYNAMIC_FROM_LINK_MAP): Test l_ld_offset instead of
> 	l_ld_size.
>         (svr4_ilp32_fetch_link_map_offsets): Don't set removed members.
> 	(svr4_lp64_fetch_link_map_offsets): Likewise.
> 
> 	* solib-legacy.c (legacy_svr4_fetch_link_map_offsets): Don't set
> 	removed members.  Set l_ld_offset to -1 if not present.