From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8626 invoked by alias); 28 Mar 2007 02:11:33 -0000 Received: (qmail 8613 invoked by uid 22791); 28 Mar 2007 02:11:31 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 28 Mar 2007 03:11:26 +0100 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 2963E4B267; Tue, 27 Mar 2007 21:11:25 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 90ACE4B262; Tue, 27 Mar 2007 21:11:24 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HWNdD-0001uV-Q5; Tue, 27 Mar 2007 22:11:23 -0400 Date: Wed, 28 Mar 2007 02:11:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Denis PILAT , gdb-patches@sourceware.org Subject: Re: [RFC] -thread-select double print stack frame Message-ID: <20070328021123.GA28506@caradoc.them.org> Mail-Followup-To: Nick Roberts , Denis PILAT , gdb-patches@sourceware.org References: <45FE948B.9090007@st.com> <17919.12645.81319.568064@kahikatea.snap.net.nz> <4607C863.7080405@st.com> <20070327193257.GM28164@caradoc.them.org> <17929.36634.510715.364996@farnswood.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17929.36634.510715.364996@farnswood.snap.net.nz> User-Agent: Mutt/1.5.14+cvs20070313 (2007-03-13) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00284.txt.bz2 On Wed, Mar 28, 2007 at 09:39:38AM +1200, Nick Roberts wrote: > Daniel Jacobowitz writes: > > On Mon, Mar 26, 2007 at 03:19:31PM +0200, Denis PILAT wrote: > > > 2007-03-26 Denis Pilat > > > > > * stack.c (print_stack_frame): alway use LOC_AND_ADDRESS in mi output. > > > * infrun.c (normal_stop): remove mi specific frame printing treatment. > > > > This is basically OK; I agree with Nick that it's the right solution. > > It needs some formatting fixes, though. > > But why do you think that while file and line details are currenly duplicated > in MI, they are not in CLI? (I mean what is the underlying logic/cause, not > the just the code differences). Here's what I get from the CLI: [Switching to thread 1 (Thread 46912506009296 (LWP 28747))]#0 main (argc=1, argv=0x7fffffffe178) at /space/fsf/commit/src/gdb/gdb.c:28 28 { The first line is the frame description and becomes the new-thread-id and the frame={} tuple. The second line ("28 {") comes from print_source_lines (from lack of ui_source_list). I think we need both, because we use print_source_lines in other contexts too, but I'm not sure about that. So the short answer is that they are duplicated in the CLI too. The two copies are just formatted so differently that it isn't obvious. This does make me wonder about the patch though. Denis, could you hold off on committing it? Which duplicate copy are you eliminating? Maybe we should diff two testsuite runs to see what else changes. -- Daniel Jacobowitz CodeSourcery