From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17093 invoked by alias); 27 Mar 2007 19:21:52 -0000 Received: (qmail 17082 invoked by uid 22791); 27 Mar 2007 19:21:51 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 27 Mar 2007 20:21:46 +0100 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 1C7254B26D; Tue, 27 Mar 2007 14:21:45 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id E7BC44B262; Tue, 27 Mar 2007 14:21:44 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HWHEm-0001WV-4J; Tue, 27 Mar 2007 15:21:44 -0400 Date: Tue, 27 Mar 2007 19:21:00 -0000 From: Daniel Jacobowitz To: Andreas Schwab Cc: gdb-patches@sourceware.org Subject: Re: Signed vs. unsigned adresses in solib-svr4 Message-ID: <20070327192144.GK28164@caradoc.them.org> Mail-Followup-To: Andreas Schwab , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.14+cvs20070313 (2007-03-13) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00272.txt.bz2 On Tue, Mar 27, 2007 at 09:16:28PM +0200, Andreas Schwab wrote: > All but two places in solib-svr4.c assume unsigned target addresses. This > patch fixes these two occurences of extract_signed_integer to make things > consistent. > > Andreas. > > 2007-03-27 Andreas Schwab > > * solib-svr4.c (LM_ADDR_FROM_LINK_MAP): Use > extract_unsigned_integer instead of extract_signed_integer. > (LM_DYNAMIC_FROM_LINK_MAP): Likewise. I'd rather not unless this fixes a real problem - since I know that the assumption is wrong for MIPS. Isn't there an extract_address or something like that which would be suitable? -- Daniel Jacobowitz CodeSourcery