From: Daniel Jacobowitz <drow@false.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] The gcore command hangs without a terminal
Date: Tue, 27 Mar 2007 16:21:00 -0000 [thread overview]
Message-ID: <20070327162041.GA3452@caradoc.them.org> (raw)
In-Reply-To: <20070225122641.GA25884@host0.dyn.jankratochvil.net>
On Sun, Feb 25, 2007 at 01:26:42PM +0100, Jan Kratochvil wrote:
> Hi,
>
> The function `attach_command' sets up the terminal by calling
> target_terminal_inferior (). This makes gcore(1) to lock up when being run
> without its controlling terminal.
>
> I do not find a reason for this terminal setup as GDB does not share its
> input/output with the application in the mode of external attached program.
Unfortunately I think this is the wrong place to fix it. You're
commenting out a call to target_terminal_inferior, but there are lots
of other calls to this function - including one any time we continue
the program.
target_terminal_inferior is a call eventually to terminal_inferior.
This checks gdb_has_a_terminal (). How are you calling GDB without a
controlling terminal that still lets gdb_has_a_terminal () return
true? That's probably the right place to fix it.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-03-27 16:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-25 12:26 Jan Kratochvil
2007-03-27 16:21 ` Daniel Jacobowitz [this message]
2007-03-27 16:40 ` Jan Kratochvil
2007-03-27 16:44 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070327162041.GA3452@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox