From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27670 invoked by alias); 19 Mar 2007 22:14:38 -0000 Received: (qmail 27661 invoked by uid 22791); 19 Mar 2007 22:14:38 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 19 Mar 2007 22:14:31 +0000 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 98C9F4B267; Mon, 19 Mar 2007 17:14:30 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 82EE24B262; Mon, 19 Mar 2007 17:14:30 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HTQ7a-0006c4-5G; Mon, 19 Mar 2007 18:14:30 -0400 Date: Mon, 19 Mar 2007 22:14:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: TUI + gdbserver broken? Message-ID: <20070319221430.GA24326@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <45FDECB3.5000002@portugalmail.pt> <20070319021145.GA25872@caradoc.them.org> <45FEF7B0.9070209@portugalmail.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45FEF7B0.9070209@portugalmail.pt> User-Agent: Mutt/1.5.14+cvs20070313 (2007-03-13) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00173.txt.bz2 On Mon, Mar 19, 2007 at 08:50:56PM +0000, Pedro Alves wrote: > Is TUI testable? Probably, but it would require someone comfortable with expect to set it up, I suspect. > Since TUI is sitting on top of deprecated hooks, it TUI itself deprecated? No. > static void > tui_selected_frame_level_changed_hook (int level) > { > struct frame_info *fi; > fi = deprecated_safe_get_selected_frame (); > /* Ensure that symbols for this frame are read in. Also, determine the > source language of this frame, and switch to it if desired. */ > if (fi) > { > struct symtab *s; How about this: if (level >= 0) { struct frame_info *fi = get_selected_frame (NULL); Insight wants to be notified even if there's no frame, apparently (gross, I hate the way Insight is still attached at the hip to GDB - I honestly believe that in a few years we'll have no choice but to break Insight). But TUI doesn't. > Here is an updated patch that also fixes the problem. > The comments in the patch should make it obvious, and I think it does > what you hinted at. No, I meant at a higher level (i.e. why we were calling the hook). The frame cache is supposed to be a cache - we should be able to discard it at any and every time. -- Daniel Jacobowitz CodeSourcery