From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30816 invoked by alias); 19 Mar 2007 02:11:55 -0000 Received: (qmail 30803 invoked by uid 22791); 19 Mar 2007 02:11:53 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 19 Mar 2007 02:11:50 +0000 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id DC3824B267; Sun, 18 Mar 2007 21:11:48 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id A11B04B262; Sun, 18 Mar 2007 21:11:46 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HT7Le-0006k9-0D; Sun, 18 Mar 2007 22:11:46 -0400 Date: Mon, 19 Mar 2007 02:11:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: TUI + gdbserver broken? Message-ID: <20070319021145.GA25872@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <45FDECB3.5000002@portugalmail.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45FDECB3.5000002@portugalmail.pt> User-Agent: Mutt/1.5.14+cvs20070313 (2007-03-13) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00162.txt.bz2 Thanks for all your detective work on this. I'm sorry I apparently broke TUI so badly - I wish we had test coverage. On Mon, Mar 19, 2007 at 01:51:47AM +0000, Pedro Alves wrote: > The problem is that we now call deprecated_safe_get_selected_frame > in tui_selected_frame_level_changed_hook... : Before I look at your patch, could you check one more thing for me: what's the backtrace look like when we get here? > The attached patch fixes it by calling target_mark_running, and > target_mark_exited in remote.c. These functions set those > target_has_* to 0 and 1 appropriately. They are currently only > used on remote-sim.c. Let me know if there is a better way to > know if the target is running. I think it is more likely that we shouldn't be doing whatever we're doing until after we've finished cleaning up the target's state. It's stuck between wait and mourn. > tui_registers_changed_hook then has the problem that is is calling > get_selected_frame, when target_has_registers is false. Fixed by > using deprecated_safe_get_selected_frame here too. This bit makes sense; you can commit it separately if you want. -- Daniel Jacobowitz CodeSourcery