From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-47982-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30991 invoked by alias); 9 Mar 2007 15:21:21 -0000
Received: (qmail 30980 invoked by uid 22791); 9 Mar 2007 15:21:20 -0000
X-Spam-Check-By: sourceware.org
Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17)     by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 09 Mar 2007 15:21:12 +0000
Received: from dsl093-172-095.pit1.dsl.speakeasy.net ([66.93.172.95] helo=caradoc.them.org) 	by nevyn.them.org with esmtp (Exim 4.63) 	(envelope-from <drow@false.org>) 	id 1HPgu5-0003TF-T1 	for gdb-patches@sourceware.org; Fri, 09 Mar 2007 10:21:09 -0500
Received: from drow by caradoc.them.org with local (Exim 4.63) 	(envelope-from <drow@caradoc.them.org>) 	id 1HPgu5-00050Q-OK 	for gdb-patches@sourceware.org; Fri, 09 Mar 2007 10:21:09 -0500
Date: Fri, 09 Mar 2007 15:21:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: [commit] Fix checkpoint.exp buffer overflow
Message-ID: <20070309152109.GA19189@caradoc.them.org>
Mail-Followup-To: gdb-patches@sourceware.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.13 (2006-08-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-03/txt/msg00113.txt.bz2

Related to Ulrich's fix for all-registers yesterday; this should
prevent expect internal errors during checkpoint.exp.  I haven't seen
one since I started testing the patch.

-- 
Daniel Jacobowitz
CodeSourcery

2007-03-09  Daniel Jacobowitz  <dan@codesourcery.com>

	* gdb.base/checkpoint.exp: Rewrite 600 checkpoint test to
	collect output incrementally.

Index: checkpoint.exp
===================================================================
RCS file: /home/gcc/repos/src/src/gdb/testsuite/gdb.base/checkpoint.exp,v
retrieving revision 1.4
diff -u -p -r1.4 checkpoint.exp
--- checkpoint.exp	9 Jan 2007 17:59:09 -0000	1.4
+++ checkpoint.exp	9 Mar 2007 13:25:11 -0000
@@ -359,8 +359,21 @@ gdb_expect {
 gdb_breakpoint $break2_loc
 gdb_test "continue" "breakpoint 2.*" "break2 with many checkpoints"
 
-gdb_test "info checkpoints" " 600 .* 0 .*" \
-    "info checkpoints with at least 600 checkpoints"
+set count 0
+set msg "info checkpoints with at least 600 checkpoints"
+gdb_test_multiple "info checkpoints" $msg {
+    -re "  $decimal process \[^\r\]*\r\n" {
+	incr count
+	exp_continue
+    }
+    -re "$gdb_prompt $" {
+	if { $count >= 600 } {
+	    pass $msg
+	} else {
+	    fail $msg
+	}
+    }
+}    
 
 #
 # OK, kill 'em all...