From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6793 invoked by alias); 9 Mar 2007 02:22:29 -0000 Received: (qmail 6779 invoked by uid 22791); 9 Mar 2007 02:22:29 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Mar 2007 02:22:22 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id l292MJu6295036 for ; Fri, 9 Mar 2007 02:22:19 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l292MJcp2064578 for ; Fri, 9 Mar 2007 03:22:19 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l292MItQ008508 for ; Fri, 9 Mar 2007 03:22:19 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l292MIOi008505; Fri, 9 Mar 2007 03:22:18 +0100 Message-Id: <200703090222.l292MIOi008505@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 9 Mar 2007 03:22:18 +0100 Subject: Re: -var-create testsuite updates [PATCH] To: nickrob@snap.net.nz (Nick Roberts) Date: Fri, 09 Mar 2007 02:22:00 -0000 From: "Ulrich Weigand" Cc: drow@false.org (Daniel Jacobowitz), gdb-patches@sourceware.org In-Reply-To: <17904.47955.434664.273574@kahikatea.snap.net.nz> from "Nick Roberts" at Mar 09, 2007 02:41:39 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00109.txt.bz2 Nick Roberts wrote: > The test is wrong. It looks like SPU initialises locals to 0. Not necessarily, but it may happen. > The value field for -var-create is new. I tried to make the regexp as specific > as possible for a more exacting test. > > If value=\"($hex).*\" works in all cases (I might have the syntax wrong, > I mean matching "0xabc" and "0xabc \"blah\"") that would be good. Otherwise > just value=\".*\" will do. value=\"$hex.*\" works for me. I've checked in the following patch. Thanks, Ulrich ChangeLog: * gdb.mi/mi-var-cmd.exp: Allow value without "..." string for -var-create lpcharacter test. * gdb.mi/mi2-var-cmd.exp: Likewise. Index: gdb/testsuite/gdb.mi/mi-var-cmd.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-var-cmd.exp,v retrieving revision 1.28 diff -u -p -r1.28 mi-var-cmd.exp --- gdb/testsuite/gdb.mi/mi-var-cmd.exp 9 Mar 2007 01:14:12 -0000 1.28 +++ gdb/testsuite/gdb.mi/mi-var-cmd.exp 9 Mar 2007 02:16:14 -0000 @@ -87,7 +87,7 @@ mi_gdb_test "-var-create lcharacter * lc "create local variable lcharacter " mi_gdb_test "-var-create lpcharacter * lpcharacter" \ - "\\^done,name=\"lpcharacter\",numchild=\"1\",value=\"$hex \\\\\".*\\\\\"\",type=\"char \\*\"" \ + "\\^done,name=\"lpcharacter\",numchild=\"1\",value=\"$hex.*\",type=\"char \\*\"" \ "create local variable lpcharacter" mi_gdb_test "-var-create llong * llong" \ Index: gdb/testsuite/gdb.mi/mi2-var-cmd.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-var-cmd.exp,v retrieving revision 1.11 diff -u -p -r1.11 mi2-var-cmd.exp --- gdb/testsuite/gdb.mi/mi2-var-cmd.exp 28 Feb 2007 17:32:51 -0000 1.11 +++ gdb/testsuite/gdb.mi/mi2-var-cmd.exp 9 Mar 2007 02:16:14 -0000 @@ -87,7 +87,7 @@ mi_gdb_test "-var-create lcharacter * lc "create local variable lcharacter " mi_gdb_test "-var-create lpcharacter * lpcharacter" \ - "\\^done,name=\"lpcharacter\",numchild=\"1\",value=\"$hex \\\\\".*\\\\\"\",type=\"char \\*\"" \ + "\\^done,name=\"lpcharacter\",numchild=\"1\",value=\"$hex.*\",type=\"char \\*\"" \ "create local variable lpcharacter" mi_gdb_test "-var-create llong * llong" \ -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com