From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17902 invoked by alias); 9 Mar 2007 01:16:23 -0000 Received: (qmail 17893 invoked by uid 22791); 9 Mar 2007 01:16:22 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.29.151) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Mar 2007 01:16:16 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.8/8.13.8) with ESMTP id l291GDUo085856 for ; Fri, 9 Mar 2007 01:16:13 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l291GCTT1900600 for ; Fri, 9 Mar 2007 02:16:12 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l291GCoC004450 for ; Fri, 9 Mar 2007 02:16:12 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l291GC7g004447; Fri, 9 Mar 2007 02:16:12 +0100 Message-Id: <200703090116.l291GC7g004447@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 9 Mar 2007 02:16:12 +0100 Subject: Re: [mi] Some error path fixes To: drow@false.org (Daniel Jacobowitz) Date: Fri, 09 Mar 2007 01:16:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20070309010238.GA5849@caradoc.them.org> from "Daniel Jacobowitz" at Mar 08, 2007 08:02:38 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00107.txt.bz2 Daniel Jacobowitz wrote: > I think you're right - the braces should be removed. OK, I've committed the following patch, which fixes the test case on spu-elf. Thanks! Bye, Ulrich ChangeLog: * gdb.mi/mi-var-cmd.exp: Allow -var-update null_ptr test to pass on targets where address zero is readable. Index: gdb/testsuite/gdb.mi/mi-var-cmd.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-var-cmd.exp,v retrieving revision 1.27 diff -u -p -r1.27 mi-var-cmd.exp --- gdb/testsuite/gdb.mi/mi-var-cmd.exp 28 Feb 2007 17:32:51 -0000 1.27 +++ gdb/testsuite/gdb.mi/mi-var-cmd.exp 9 Mar 2007 01:11:37 -0000 @@ -603,7 +603,7 @@ mi_gdb_test "-var-create null_ptr * **0" # will not test what it was meant to. Most important is that GDB # does not crash. mi_gdb_test "-var-update null_ptr" \ - {\^done,changelist=\[{.*}\]} \ + {\^done,changelist=\[.*\]} \ "update null_ptr" mi_gdb_test "-var-delete null_ptr" \ -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com