Re: [Patch]: Little Cleanup

Eli Zaretskii
2007-03-03T10:29:06Z

> Date: Sat, 03 Mar 2007 09:07:49 +0000
> From: Pedro Alves <pedro_alves@portugalmail.pt>
> CC: GDB Patches <gdb-patches@sourceware.org>
>
> Markus Deuling wrote:
> > @@ -2909,8 +2902,7 @@
> >
> > if (!breakpoints_inserted && !ecs->another_trap)
> > {
> > - breakpoints_failed = insert_breakpoints ();
> > - if (breakpoints_failed)
> > + if (insert_breakpoints ())
> > {
> > stop_stepping (ecs);
> > return;
> >
> >
>
> Actually, I find your version harder to read for someone not knowing the
> insert_breakpoints API by heart.

FWIW, I agree. The new version requires a comment to be as readable
as the old one.

(Of course, I'd expect the optimizer to produce the same code from
both old and new versions.)