From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-47919-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7880 invoked by alias); 5 Mar 2007 21:23:50 -0000
Received: (qmail 7869 invoked by uid 22791); 5 Mar 2007 21:23:48 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 05 Mar 2007 21:23:39 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.0/8.14.0) with ESMTP id l25LJKKB015505; 	Mon, 5 Mar 2007 22:19:20 +0100 (CET)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.0/8.14.0/Submit) id l25LJKVw021917; 	Mon, 5 Mar 2007 22:19:20 +0100 (CET)
Date: Mon, 05 Mar 2007 21:23:00 -0000
Message-Id: <200703052119.l25LJKVw021917@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: eliz@gnu.org
CC: deuling@de.ibm.com, pedro_alves@portugalmail.pt,         gdb-patches@sourceware.org
In-reply-to: <uvehfmmfj.fsf@gnu.org> (message from Eli Zaretskii on Mon, 05 	Mar 2007 23:04:48 +0200)
Subject: Re: [Patch]: Little Cleanup
References: <45E7CC17.5040304@de.ibm.com> <45E93AE5.5050704@portugalmail.pt> <ulkie62od.fsf@gnu.org> <45EBB15E.4000602@de.ibm.com> <uvehfmmfj.fsf@gnu.org>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-03/txt/msg00050.txt.bz2

> Date: Mon, 05 Mar 2007 23:04:48 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Date: Mon, 05 Mar 2007 06:57:50 +0100
> > From: Markus Deuling <deuling@de.ibm.com>
> > CC: Pedro Alves <pedro_alves@portugalmail.pt>, gdb-patches@sourceware.org
> > 
> >        if (!breakpoints_inserted && !ecs->another_trap)
> >  	{
> > -	  breakpoints_failed = insert_breakpoints ();
> > -	  if (breakpoints_failed)
> > +          if (insert_breakpoints () != 0)
> >  	    {
> >  	      stop_stepping (ecs);
> >  	      return;
> 
> I thought we agreed about adding a comment here, something like:
> 
>   /* insert_breakpoints returns non-zero if it fails to insert the
>      breakpoints.  */

Adding this sort of comments at all call sites of such functions is
really silly.

Mark