From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7527 invoked by alias); 5 Mar 2007 12:45:58 -0000 Received: (qmail 7504 invoked by uid 22791); 5 Mar 2007 12:45:56 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 05 Mar 2007 12:45:49 +0000 Received: from dsl093-172-095.pit1.dsl.speakeasy.net ([66.93.172.95] helo=caradoc.them.org) by nevyn.them.org with esmtp (Exim 4.63) (envelope-from ) id 1HOCZX-0001w7-2u; Mon, 05 Mar 2007 07:45:47 -0500 Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HOCZW-0003vt-UR; Mon, 05 Mar 2007 07:45:46 -0500 Date: Mon, 05 Mar 2007 12:45:00 -0000 From: Daniel Jacobowitz To: insight@sourceware.org Cc: gdb-patches@sourceware.org Subject: Re: [rfc] Remove deprecated_selected_frame Message-ID: <20070305124546.GC14835@caradoc.them.org> Mail-Followup-To: insight@sourceware.org, gdb-patches@sourceware.org References: <20070222212909.GA17260@caradoc.them.org> <45EA394A.1C292B19@dessent.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45EA394A.1C292B19@dessent.net> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00037.txt.bz2 On Sat, Mar 03, 2007 at 07:13:14PM -0800, Brian Dessent wrote: > It looks like there are about a dozen more references in > gdbtk/generic/gdbtk-{cmds,hooks,register,stack}.c. Most of them seem to > be the "if (deprecated_selected_frame != NULL)" sort of thing -- is this > safe to just replace with "if (get_selected_frame (NULL))" ? I don't know. It depends if they're supposed to work when the program isn't running or not. You may want to use deprecated_safe_get_selected_frame if they are, and get_selected_frame anywhere that assumes the program is running. -- Daniel Jacobowitz CodeSourcery