From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15165 invoked by alias); 28 Feb 2007 19:24:16 -0000 Received: (qmail 15154 invoked by uid 22791); 28 Feb 2007 19:24:16 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 28 Feb 2007 19:24:05 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id BEA9E48CEE6 for ; Wed, 28 Feb 2007 14:24:03 -0500 (EST) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 15030-01-7 for ; Wed, 28 Feb 2007 14:24:03 -0500 (EST) Received: from takamaka.act-europe.fr (unknown [70.71.0.212]) by nile.gnat.com (Postfix) with ESMTP id 7618748CE53 for ; Wed, 28 Feb 2007 14:24:03 -0500 (EST) Received: by takamaka.act-europe.fr (Postfix, from userid 1000) id 3ACD5E7972; Wed, 28 Feb 2007 11:24:10 -0800 (PST) Date: Wed, 28 Feb 2007 19:24:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [RFA] Fix typo in replace type Message-ID: <20070228192410.GM28322@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="2fHTh5uZTiUOsy+g" Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00384.txt.bz2 --2fHTh5uZTiUOsy+g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 907 This is a followup on something that was discovered while reviewing a stabs patch: http://www.sourceware.org/ml/gdb-patches/2007-02/msg00139.html In particular, this is where we discovered this little typo: http://www.sourceware.org/ml/gdb-patches/2007-02/msg00368.html I confirm that I misanalyzed the second problem I mentioned in my original message, and that this is the source of the issue I was seeing: Breakpoint 1, pck.lock.set (x=Unrecognized 0-bit floating-point type. ) at pck.adb:11 Basically, the effect of the typo is that we forgot to update the type length of the other types in the same CV ring. Fixed thusly. 2007-02-28 Joel Brobecker * gdbtypes.c (replace_type): Fix typo that caused us to not update length of the types referenced by the new type CV ring. Tested on x86-linux, no regression. OK to apply? Thanks, -- Joel --2fHTh5uZTiUOsy+g Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="replace_type.diff" Content-length: 581 Index: gdbtypes.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtypes.c,v retrieving revision 1.113 diff -u -p -r1.113 gdbtypes.c --- gdbtypes.c 28 Feb 2007 16:35:48 -0000 1.113 +++ gdbtypes.c 28 Feb 2007 19:09:56 -0000 @@ -636,7 +636,7 @@ replace_type (struct type *ntype, struct call replace_type(). */ gdb_assert (TYPE_ADDRESS_CLASS_ALL (chain) == 0); - TYPE_LENGTH (ntype) = TYPE_LENGTH (type); + TYPE_LENGTH (chain) = TYPE_LENGTH (type); chain = TYPE_CHAIN (chain); } while (ntype != chain); --2fHTh5uZTiUOsy+g--