From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31222 invoked by alias); 27 Feb 2007 23:08:04 -0000 Received: (qmail 31213 invoked by uid 22791); 27 Feb 2007 23:08:04 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 27 Feb 2007 23:07:58 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id 7F91348CE70 for ; Tue, 27 Feb 2007 18:07:55 -0500 (EST) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 12042-01-4 for ; Tue, 27 Feb 2007 18:07:55 -0500 (EST) Received: from takamaka.act-europe.fr (unknown [70.71.0.212]) by nile.gnat.com (Postfix) with ESMTP id 5790148D05C for ; Tue, 27 Feb 2007 18:07:50 -0500 (EST) Received: by takamaka.act-europe.fr (Postfix, from userid 1000) id 68833E7972; Tue, 27 Feb 2007 15:07:55 -0800 (PST) Date: Tue, 27 Feb 2007 23:08:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [RFA] Fix crash when DW_AT_producer attribute is absent Message-ID: <20070227230755.GA13140@adacore.com> References: <20070227044623.GA13159@adacore.com> <20070227120345.GA5622@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070227120345.GA5622@caradoc.them.org> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00358.txt.bz2 > > The crash happens because we do the following inside dwarf2read.c: > > > > attr = dwarf2_attr (die, DW_AT_producer, cu); > > if (attr) > > cu->producer = DW_STRING (attr); > > [...] > > record_producer (cu->producer); > > > > (but cu->producer is NULL) > > OK and thanks. Thanks Daniel. Checked in. -- Joel