From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8635 invoked by alias); 27 Feb 2007 17:32:46 -0000 Received: (qmail 8621 invoked by uid 22791); 27 Feb 2007 17:32:45 -0000 X-Spam-Check-By: sourceware.org Received: from pool-71-248-179-54.bstnma.fios.verizon.net (HELO cgf.cx) (71.248.179.54) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 27 Feb 2007 17:32:30 +0000 Received: by cgf.cx (Postfix, from userid 201) id E38D213C01F; Tue, 27 Feb 2007 12:32:28 -0500 (EST) Date: Tue, 27 Feb 2007 17:32:00 -0000 From: Christopher Faylor To: overseers@sourceware.org, gdb-patches@sourceware.org, Nathan Froyd Subject: Re: [PATCH] fix assertion when returning from initial frame Message-ID: <20070227173228.GA32404@trixie.casa.cgf.cx> Mail-Followup-To: overseers@sourceware.org, gdb-patches@sourceware.org, Nathan Froyd References: <20070221162434.GL4200@sparrowhawk.codesourcery.com> <20070227171610.GJ31729@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070227171610.GJ31729@caradoc.them.org> User-Agent: Mutt/1.5.11 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00345.txt.bz2 On Tue, Feb 27, 2007 at 12:16:10PM -0500, Daniel Jacobowitz wrote: >On Wed, Feb 21, 2007 at 08:24:35AM -0800, Nathan Froyd wrote: >> The following patch fixes an assertion when a user attempts to return >> from the initial frame (or a frame for which GDB cannot find the >> previous frame due to limited debugging information). frame_pop always >> assumed that a previous frame could be found; it now checks that it >> actually finds a previous frame before proceeding. >> >> OK? (I do not have gdb commit privileges.) > >This is OK. Let's get you write access; then you can check it in, and >add yourself to gdb/MAINTAINERS write after approval. > >Overseers, could you please add "froydnj" to the src group on >sourceware? Thanks in advance. Done. cgf