From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32577 invoked by alias); 27 Feb 2007 17:16:24 -0000 Received: (qmail 32559 invoked by uid 22791); 27 Feb 2007 17:16:23 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 27 Feb 2007 17:16:14 +0000 Received: from dsl093-172-095.pit1.dsl.speakeasy.net ([66.93.172.95] helo=caradoc.them.org) by nevyn.them.org with esmtp (Exim 4.63) (envelope-from ) id 1HM5vv-0007uY-3f; Tue, 27 Feb 2007 12:16:11 -0500 Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HM5vu-0000LH-TG; Tue, 27 Feb 2007 12:16:10 -0500 Date: Tue, 27 Feb 2007 17:16:00 -0000 From: Daniel Jacobowitz To: Nathan Froyd Cc: gdb-patches@sourceware.org, overseers@sourceware.org Subject: Re: [PATCH] fix assertion when returning from initial frame Message-ID: <20070227171610.GJ31729@caradoc.them.org> Mail-Followup-To: Nathan Froyd , gdb-patches@sourceware.org, overseers@sourceware.org References: <20070221162434.GL4200@sparrowhawk.codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070221162434.GL4200@sparrowhawk.codesourcery.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00339.txt.bz2 On Wed, Feb 21, 2007 at 08:24:35AM -0800, Nathan Froyd wrote: > The following patch fixes an assertion when a user attempts to return > from the initial frame (or a frame for which GDB cannot find the > previous frame due to limited debugging information). frame_pop always > assumed that a previous frame could be found; it now checks that it > actually finds a previous frame before proceeding. > > OK? (I do not have gdb commit privileges.) This is OK. Let's get you write access; then you can check it in, and add yourself to gdb/MAINTAINERS write after approval. Overseers, could you please add "froydnj" to the src group on sourceware? Thanks in advance. -- Daniel Jacobowitz CodeSourcery