From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13251 invoked by alias); 27 Feb 2007 16:50:19 -0000 Received: (qmail 13241 invoked by uid 22791); 27 Feb 2007 16:50:17 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 27 Feb 2007 16:50:07 +0000 Received: from dsl093-172-095.pit1.dsl.speakeasy.net ([66.93.172.95] helo=caradoc.them.org) by nevyn.them.org with esmtp (Exim 4.63) (envelope-from ) id 1HM5Wd-0007tE-RS; Tue, 27 Feb 2007 11:50:03 -0500 Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HM5Wd-0008RZ-Lc; Tue, 27 Feb 2007 11:50:03 -0500 Date: Tue, 27 Feb 2007 16:50:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Enhance stabs reader to better deal with forward references Message-ID: <20070227165003.GB31729@caradoc.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20070209194107.GA3365@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070209194107.GA3365@adacore.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00332.txt.bz2 On Fri, Feb 09, 2007 at 11:41:07AM -0800, Joel Brobecker wrote: > That's not where the fun stops, however. The code handling > const types looks like this: > > case 'k': /* Const qualifier on some type (Sun) */ > type = read_type (pp, objfile); > type = make_cv_type (1, TYPE_VOLATILE (type), type, > dbx_lookup_type (typenums)); > break; > > In our case, the "make_type" call ended up returning an undefined > type, and then we end up making a "const" copy of that undefined > type when calling "make_cv_type". > > The problem is that type 268 (our const type) is "complete", and > no future stabs entry will ammend it. So even though I some handling > for forward references of the kind above, this was not sufficient > because the type attached to our parameter was still an undefined > type. > > That's why I modified this part of the code to make the cv type > only when the target type was already defined. Otherwise, we give > up the "const" qualifier and reuse the target type instead. We > know that this target type will be fixed up later, so our parameter > will have a defined type, and we'll be able to print it. We end up > losing the "const" qualifier, but this is still way better than > not having any type at all. I really don't like this part. I don't understand it, either. Why is the CV type complete? When the non-qualified type is filled in, that should automatically fill this in, because of the CV ring. See the implementation of replace_type. -- Daniel Jacobowitz CodeSourcery