From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6293 invoked by alias); 27 Feb 2007 12:03:57 -0000 Received: (qmail 6283 invoked by uid 22791); 27 Feb 2007 12:03:56 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 27 Feb 2007 12:03:48 +0000 Received: from dsl093-172-095.pit1.dsl.speakeasy.net ([66.93.172.95] helo=caradoc.them.org) by nevyn.them.org with esmtp (Exim 4.63) (envelope-from ) id 1HM13Z-0007Xg-9N; Tue, 27 Feb 2007 07:03:45 -0500 Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HM13Z-0001US-2E; Tue, 27 Feb 2007 07:03:45 -0500 Date: Tue, 27 Feb 2007 12:03:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix crash when DW_AT_producer attribute is absent Message-ID: <20070227120345.GA5622@caradoc.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20070227044623.GA13159@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070227044623.GA13159@adacore.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00327.txt.bz2 On Mon, Feb 26, 2007 at 08:46:23PM -0800, Joel Brobecker wrote: > The crash happens because we do the following inside dwarf2read.c: > > attr = dwarf2_attr (die, DW_AT_producer, cu); > if (attr) > cu->producer = DW_STRING (attr); > [...] > record_producer (cu->producer); > > (but cu->producer is NULL) Whoops, that was sloppy of me. OK and thanks. -- Daniel Jacobowitz CodeSourcery