From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro_alves@portugalmail.pt>
Cc: gdb-patches@sourceware.org
Subject: Re: [gdbserver] Use enum target_signal in _send_signal.
Date: Sun, 25 Feb 2007 02:11:00 -0000 [thread overview]
Message-ID: <20070225021135.GA20988@caradoc.them.org> (raw)
In-Reply-To: <45E0C90C.7030101@portugalmail.pt>
On Sat, Feb 24, 2007 at 11:23:56PM +0000, Pedro Alves wrote:
> Hi all,
>
> This patch converts the send_signal function in target_ops to use enum
> target_signal
> instead of the real target number. I originally needed this for the
> WinCE gdbserver port.
> Windows CE doesn't have signals support, and doesn't define SIGINT in
> any header.
> Because of that, remote-utils.c wouldn't compile. I still want to have
> support of stopping
> a debuggee - this patch paves the way to that, with minimal interface
> changes. I will handle
> TARGET_SIGNAL_INT in the send_signal handler on the target side.
>
> Ok?
Maybe this is the wrong abstraction entirely? Because most signals
are passed to the continue / resume support, maybe the target method
here doesn't need a signal number at all. We could replace it with
just send_interrupt.
What do you think?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-02-25 2:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-24 23:24 Pedro Alves
2007-02-25 2:11 ` Daniel Jacobowitz [this message]
2007-02-25 3:20 ` Pedro Alves
2007-02-25 17:22 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070225021135.GA20988@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro_alves@portugalmail.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox