From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2284 invoked by alias); 22 Feb 2007 15:15:39 -0000 Received: (qmail 2267 invoked by uid 22791); 22 Feb 2007 15:15:39 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.29.150) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 22 Feb 2007 15:15:33 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.8/8.13.8) with ESMTP id l1MFFUK2086588 for ; Thu, 22 Feb 2007 15:15:30 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.2) with ESMTP id l1MFFU4Q2158776 for ; Thu, 22 Feb 2007 16:15:30 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l1MFFUsb003554 for ; Thu, 22 Feb 2007 16:15:30 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l1MFFTPb003541; Thu, 22 Feb 2007 16:15:29 +0100 Message-Id: <200702221515.l1MFFTPb003541@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 22 Feb 2007 16:15:29 +0100 Subject: Re: Patch: Fix handling for TYPE_CODE_INT in valops.c To: drow@false.org (Daniel Jacobowitz) Date: Thu, 22 Feb 2007 15:15:00 -0000 From: "Ulrich Weigand" Cc: deuling@de.ibm.com (Markus Deuling), gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <20070222145729.GC2036@caradoc.them.org> from "Daniel Jacobowitz" at Feb 22, 2007 09:57:29 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00266.txt.bz2 Daniel Jakobowitz wrote: > On Thu, Feb 22, 2007 at 03:33:10PM +0100, Markus Deuling wrote: > > The architecture specific callback integer_to_address() isn't called, so > > that's why in this case 0x2b50 isn't converted to a combined address as it > > should. The patch calls value_as_address instead of value_as_long to handle > > a TYPE_CODE_INT. > > > > Running the test suite showed no regressions both on x86 and SPU. > > > > Ok to commit ? > > Yes, I think this is OK. Thanks. I've checked this in as well, thanks. -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com