From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14696 invoked by alias); 22 Feb 2007 14:57:38 -0000 Received: (qmail 14681 invoked by uid 22791); 22 Feb 2007 14:57:38 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 22 Feb 2007 14:57:31 +0000 Received: from dsl093-172-095.pit1.dsl.speakeasy.net ([66.93.172.95] helo=caradoc.them.org) by nevyn.them.org with esmtp (Exim 4.63) (envelope-from ) id 1HKFNx-0001F5-Lt; Thu, 22 Feb 2007 09:57:29 -0500 Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HKFNx-0000ZQ-Eh; Thu, 22 Feb 2007 09:57:29 -0500 Date: Thu, 22 Feb 2007 14:57:00 -0000 From: Daniel Jacobowitz To: Markus Deuling Cc: GDB Patches , Ulrich Weigand Subject: Re: Patch: Fix handling for TYPE_CODE_INT in valops.c Message-ID: <20070222145729.GC2036@caradoc.them.org> Mail-Followup-To: Markus Deuling , GDB Patches , Ulrich Weigand References: <45DDA9A6.7040502@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45DDA9A6.7040502@de.ibm.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00264.txt.bz2 On Thu, Feb 22, 2007 at 03:33:10PM +0100, Markus Deuling wrote: > The architecture specific callback integer_to_address() isn't called, so > that's why in this case 0x2b50 isn't converted to a combined address as it > should. The patch calls value_as_address instead of value_as_long to handle > a TYPE_CODE_INT. > > Running the test suite showed no regressions both on x86 and SPU. > > Ok to commit ? Yes, I think this is OK. Thanks. -- Daniel Jacobowitz CodeSourcery