From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21512 invoked by alias); 17 Feb 2007 14:31:24 -0000 Received: (qmail 21500 invoked by uid 22791); 17 Feb 2007 14:31:23 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 17 Feb 2007 14:31:14 +0000 Received: (qmail 22876 invoked from network); 17 Feb 2007 14:31:12 -0000 Received: from unknown (HELO ?172.16.64.38?) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 17 Feb 2007 14:31:12 -0000 From: Vladimir Prus To: Eli Zaretskii Subject: Re: "target remote | " stderr Date: Sat, 17 Feb 2007 14:31:00 -0000 User-Agent: KMail/1.9.1 Cc: gdb-patches@sources.redhat.com References: <200701261653.53834.vladimir@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200702171730.58867.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00217.txt.bz2 On Saturday 17 February 2007 13:56, Eli Zaretskii wrote: > > From: Vladimir Prus > > Date: Sat, 17 Feb 2007 10:34:36 +0300 > > > > >> + int error_fd; /* File descriptor for a separate > > >> + error stream that should be > > >> + immediately forwarded to gdb_stderr. > > >> + This may be -1. > > >> + If != -1, this descriptor should > > >> + be non-blocking. */ > > > > > > This comment isn't according to GNU coding standards, I think. > > > > Can you please be more specific? > > Not sure what you want me to say. Well... > Multiline, multiple-sentence > comments should not be alongside of the code, they should precede the > code. ... the above. With your original comment I went looking for missing double spaces, found none, and had no idea what you mean. - Volodya