From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18507 invoked by alias); 13 Feb 2007 22:49:32 -0000 Received: (qmail 18499 invoked by uid 22791); 13 Feb 2007 22:49:31 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 13 Feb 2007 22:49:25 +0000 Received: from dsl093-172-095.pit1.dsl.speakeasy.net ([66.93.172.95] helo=caradoc.them.org) by nevyn.them.org with esmtp (Exim 4.63) (envelope-from ) id 1HH6Sg-0000OD-RJ; Tue, 13 Feb 2007 17:49:22 -0500 Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HH6Sg-0006hp-4W; Tue, 13 Feb 2007 17:49:22 -0500 Date: Tue, 13 Feb 2007 22:49:00 -0000 From: Daniel Jacobowitz To: Tim Auton Cc: gdb-patches@sourceware.org Subject: Re: Remote Debugging Protocol - hex case Message-ID: <20070213224921.GA25525@caradoc.them.org> Mail-Followup-To: Tim Auton , gdb-patches@sourceware.org References: <842A2789-AFD7-4339-8E5E-608D6C9CFDD7@uton.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <842A2789-AFD7-4339-8E5E-608D6C9CFDD7@uton.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00188.txt.bz2 On Tue, Feb 13, 2007 at 09:45:41PM +0000, Tim Auton wrote: > As far as I can see, making remote debugging support upper-case hex > properly won't be much trouble. It pretty much amounts to replacing the > disparate error checking in remote.c with calls to > packet_check_result(). But it's quite possible that I'm missing wider > repercussions which are obvious to someone who knows GDB and the source > much better than me (which is probably most of you). As far as I know, you are correct - it's just a matter of cleanup. The "more correct" functions you mention are much newer, and it's hard to test some of the older bits of the file - that's why not much has happened. > 1) Patch remote.c to support upper-case hex consistently, update docs to > suggest lower-case for backward compatibility. > > Pros: Consistent with the rest of GDB, which generally supports > upper-case hex. > > Cons: Any stubs which don't provide a two-digit errno or a > E.something > string will break. (Do any exist?) I think they are sufficiently broken that we should not bend over backwards to support them (though recognizing "ENN" as an error might be useful - a recent PR was at least the second time I've seen someone do that.) > I'm happy to write and submit the patches once the maintainers decide on > the best course of action, though as I'm not intimate with GDB's > internals and don't (yet) have the first clue about texinfo (but am > wiling to learn), the maintainers may wish to be more circumspect than > ususal in checking them. I've found the GNU coding standards, but > pointers to anything else relevant would be well received (off-list, if > appropriate). That, and the list archives, should be fine as references. I'd be glad to review patches in this area. Please note that this would be non-trivial work, so it would require an FSF copyright assignment for GDB - let me know if you're able and willing to do that (or have one already). -- Daniel Jacobowitz CodeSourcery