From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13216 invoked by alias); 9 Feb 2007 20:24:31 -0000 Received: (qmail 13204 invoked by uid 22791); 9 Feb 2007 20:24:30 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Feb 2007 20:24:24 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id 88DB248CC69; Fri, 9 Feb 2007 15:24:22 -0500 (EST) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 07648-01-6; Fri, 9 Feb 2007 15:24:22 -0500 (EST) Received: from takamaka.act-europe.fr (unknown [70.71.0.212]) by nile.gnat.com (Postfix) with ESMTP id 3DF4748CC66; Fri, 9 Feb 2007 15:24:22 -0500 (EST) Received: by takamaka.act-europe.fr (Postfix, from userid 1000) id 41F5D34C099; Fri, 9 Feb 2007 12:25:27 -0800 (PST) Date: Fri, 09 Feb 2007 20:24:00 -0000 From: Joel Brobecker To: Gabriel Dos Reis Cc: gdb-patches@sourceware.org, dan@codesourcery.com Subject: Re: PATCH to gdb/ada-lang.c Message-ID: <20070209202527.GF3365@adacore.com> References: <8764ab4iy2.fsf@soliton.cs.tamu.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8764ab4iy2.fsf@soliton.cs.tamu.edu> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00145.txt.bz2 Hello Gaby, Thanks for your patch. > 2007-02-09 Gabriel Dos Reis > > * ada-lang.c (remove_out_of_scope_renamings): Change third parameter's > type to a pointer to const struct block. > (ada_lookup_symbol_list): Don't cast away constness when calling > remove_out_of_scope_renamings. I had a look, and although I cannot approve your change, I agree with your conclusions and your patch. -- Joel