Re: [PATCH] MI: Add value field to output of -var-create

Vladimir Prus
2007-01-05T07:40:42Z

On Friday 05 January 2007 02:22, Nick Roberts wrote:
> > I think this is a good change in general. However, the problem is that
> > a lot of tests hardcode the output from -var-create, and are broken with
> > this change. I think that instead of adding more hardcoding, we'd
> > need to replace all creation of varobjs with calls to mi_create_varobj.
> > Would you be willing to do that?
>
> It seems unfortunate to me that the output from -var-create gets tested so many
> times but Daniel has just said that mi_gdb_test should really should used even
> if you don't care about the result.

FWIW, mi_create_varobj does use mi_gdb_test.

> Real tests for -var-create e.g in
> mi-var-cmd.exp need to be looked at more carefully (some test when -var-create
> fails) but, sure, mi_create_varobj could be used when you don't care about the
> result.

Good. Yes, it's unfortunate that the work on updating tests far exceeds the work
to make the patch itself, but at this point we can only try to avoid this in future ;-)

- Volodya