From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18105 invoked by alias); 8 Feb 2007 20:25:06 -0000 Received: (qmail 18082 invoked by uid 22791); 8 Feb 2007 20:25:03 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 08 Feb 2007 20:24:52 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1HFFp4-0007Il-K9; Thu, 08 Feb 2007 15:24:50 -0500 Date: Thu, 08 Feb 2007 20:25:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] MI: Add value field to output of -var-create Message-ID: <20070208202450.GA27835@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17818.12006.696879.216415@kahikatea.snap.net.nz> <20070105150747.GD24554@nevyn.them.org> <17839.14615.772612.987502@kahikatea.snap.net.nz> <20070120190903.GA22153@nevyn.them.org> <17842.36650.58436.387233@kahikatea.snap.net.nz> <17860.5394.631978.403208@kahikatea.snap.net.nz> <20070204140955.GA8764@nevyn.them.org> <17862.21280.730210.678232@kahikatea.snap.net.nz> <20070208175749.GA17845@nevyn.them.org> <17867.33519.93541.517510@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17867.33519.93541.517510@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00095.txt.bz2 On Fri, Feb 09, 2007 at 09:07:11AM +1300, Nick Roberts wrote: > It doesn't display properly in Emacs without a * on each line e.g look at > this change in Emacs: Yours doesn't look right in emacs either; spaces instead of tabs disables the highlighting, and the old date. I fixed it. > I kept the *'s but removed the commas. This style is used by the Emacs > project, at least. The convention used there is that if different files > have different changes then a blank line is left between the ChangeLog entries, > but if the changes are the same then the entries are contiguous. I really don't care enough about changelog formatting to argue about it. But I will observe one thing: this is GDB, not Emacs, and it's always more polite to match the style of the file you are changing. Emacs seems split about 50-50. -- Daniel Jacobowitz CodeSourcery