From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13436 invoked by alias); 8 Feb 2007 23:05:11 -0000 Received: (qmail 13422 invoked by uid 22791); 8 Feb 2007 23:05:11 -0000 X-Spam-Check-By: sourceware.org Received: from w099.z064220152.sjc-ca.dsl.cnc.net (HELO bluesmobile.specifix.com) (64.220.152.99) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 08 Feb 2007 23:05:06 +0000 Received: from fishpond.diveadx.com (bluesmobile.corp.specifix.com [192.168.1.32]) by bluesmobile.specifix.com (Postfix) with ESMTP id 6820F3B8CF; Thu, 8 Feb 2007 15:05:04 -0800 (PST) From: Fred Fish Reply-To: fnf@specifix.com To: Mark Kettenis Subject: Re: [RFC] Patch to add kernel threads support for FreeBSD 6.1 Date: Thu, 08 Feb 2007 23:05:00 -0000 User-Agent: KMail/1.9.5 Cc: gdb-patches@sources.redhat.com, fnf@specifix.com References: <200702061718.47875.fnf@specifix.com> <200702082147.l18Ll7NU005756@brahms.sibelius.xs4all.nl> In-Reply-To: <200702082147.l18Ll7NU005756@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200702081605.01875.fnf@specifix.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00115.txt.bz2 On Thursday 08 February 2007 14:47, Mark Kettenis wrote: > Can you avoid introducing supply_xxregset()/fill_xxregset() and use > register sets instead? OK. > Is the child_suppress_run hack really necessary? I thought the right > stratum was automatically chosen. It was introduced to work around the issue that you can't have two targets ready to run at the same time, apparently. That's an area I'm not intimately familar with. I believe the patch originated in some BSD code. > > +#define GET_PID(ptid) ptid_get_pid (ptid) > > +#define GET_LWP(ptid) ptid_get_lwp (ptid) > > +#define GET_THREAD(ptid) ptid_get_tid (ptid) > > + > > +#define IS_LWP(ptid) (GET_LWP (ptid) != 0) > > +#define IS_THREAD(ptid) (GET_THREAD (ptid) != 0) > > + > > +#define BUILD_LWP(lwp, pid) ptid_build (pid, lwp, 0) > > +#define BUILD_THREAD(tid, pid) ptid_build (pid, 0, tid) > > These days these macros are really pointless and I think they should > die (here and elsewhere in the code). Fine by me. :-) Of course this is somewhat of a moot point if the fact that the main support file comes directly from FreeBSD prevents this patch from going into mainline gdb. -Fred