From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2610 invoked by alias); 8 Feb 2007 14:34:05 -0000 Received: (qmail 2598 invoked by uid 22791); 8 Feb 2007 14:34:03 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 08 Feb 2007 14:33:46 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1HFALA-0001tb-FU; Thu, 08 Feb 2007 09:33:36 -0500 Date: Thu, 08 Feb 2007 14:34:00 -0000 From: Daniel Jacobowitz To: Fred Fish Cc: Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: [RFC] Patch for QUIT macro support Message-ID: <20070208143336.GB6861@nevyn.them.org> Mail-Followup-To: Fred Fish , Mark Kettenis , gdb-patches@sources.redhat.com References: <200610130543.25806.fnf@specifix.com> <200610130648.31875.fnf@specifix.com> <200610151800.k9FI0fDS016688@elgar.sibelius.xs4all.nl> <200701220740.53051.fnf@specifix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200701220740.53051.fnf@specifix.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00074.txt.bz2 On Mon, Jan 22, 2007 at 07:40:52AM -0700, Fred Fish wrote: > On Sunday 15 October 2006 11:00, Mark Kettenis wrote: > > We really should not put history in our comments. > > Good point. Here is a patch with updated comments. > > It would be good if someone could independently review, test, and > approve this, particularly anyone using an interface other than the > normal command line one. > 2007-01-22 Fred Fish > > * event-top.c (handle_sigint): Set quit_flag. > (async_request_quit): Don't set quit_flag. Avoid calling quit() > if quit_flag has already been reset. Well, I independently reviewed it - I think this is correct. I can't readily test it with any other interface at the moment, but I think you should commit this. We'll have a while to catch any problems if there's something we didn't think of. -- Daniel Jacobowitz CodeSourcery