From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3271 invoked by alias); 6 Feb 2007 12:49:21 -0000 Received: (qmail 3256 invoked by uid 22791); 6 Feb 2007 12:49:19 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 06 Feb 2007 12:49:12 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1HEPl0-0008DH-Ih; Tue, 06 Feb 2007 07:49:10 -0500 Date: Tue, 06 Feb 2007 12:49:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: XML XInclude support Message-ID: <20070206124910.GA31162@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , gdb-patches@sourceware.org References: <20070129213229.GA17422@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00051.txt.bz2 On Fri, Feb 02, 2007 at 08:53:32PM +0200, Eli Zaretskii wrote: > > + /* Simple, portable version of dirname that does not modify its > > + argument. */ > > + base = lbasename (filename); > > + while (base > filename && IS_DIR_SEPARATOR (base[-1])) > > + --base; > > I'm glad to see portable file-name handling, but this loop needs a > small extra to not fail in the case of "d:foo". Does it? lbasename ("d:foo") will return a pointer to the 'f'. At that point base > filename is true, but IS_DIR_SEPARATOR is false, so we use "d:" as the directory name. If that's wrong, I don't know enough about DOS based filesystems to know why. > I'd suggest to use @var{document} instead of @var{name}, and reword > the last sentence like this: Is this better? @noindent When @value{GDBN} encounters an element of this form, it will retrieve the named XML @var{document}, and replace the inclusion directive with the contents of that document. If the current description was read using @samp{qXfer}, then so will be the included document; @var{document} will be interpreted as the name of an annex. If the current description was read from a file, @value{GDBN} will look for @var{document} as a file in the same directory where it found the original description. -- Daniel Jacobowitz CodeSourcery