Re: [RFC] thread apply commands change selected frame

Denis PILAT
2007-01-31T19:30:40Z

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

> The default name for a test is the command, if you don't specify a
> name. These are pretty generic commands, but test names are supposed
> to be unique within a .exp file. I would recommend giving them names
> (and probably checking their output, at least a little, too...).
>
>

Your remarks have been taken into account into the attached patch.
Are you ok for committing this one plus the previous patch regarding the
thread.c ?
(Frederic Riss will do that for me)

--
Denis Pilat
STMicroelectronics

[-- Attachment #2: threadapply.exp.patch --]
[-- Type: text/plain, Size: 1176 bytes --]

2007-01-31 Denis Pilat <denis.pilat@st.com>

* gdb.threads/threadapply.exp: check that frame is not changed by
the thread apply all command.

Index: testsuite/gdb.threads/threadapply.exp
===================================================================
--- testsuite/gdb.threads/threadapply.exp (revision 553)
+++ testsuite/gdb.threads/threadapply.exp (working copy)
@@ -69,3 +69,9 @@ gdb_test_multiple "define backthread" "d
gdb_test "set backtrace limit 3" ""
gdb_test "thread apply all backthread" "Thread ..*\\\$1 = 0x14.*Thread ..*\\\$2 = 0x14.*Thread ..*\\\$3 = 0x14.*Thread ..*\\\$4 = 0x14.*Thread ..*\\\$5 = 0x14.*Thread ..*\\\$. = 0x14"

+# Go into the thread_function to check that a simple "thread apply"
+# does not change the selected frame.
+gdb_test "step" "thread_function.*" "step to the thread_function"
+gdb_test "up" ".*in main.*" "go up in the stack frame"
+gdb_test "thread apply all print 1" "Thread ..*\\\$7 = 1.*Thread ..*\\\$8 = 1.*Thread ..*\\\$9 = 1.*Thread ..*\\\$10 = 1.*Thread ..*\\\$11 = 1.*Thread ..*\\\$12 = 1" "run a simple print command on all thread"
+gdb_test "down" "#0.*thread_function.*" "go down and check selected frame"