From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31268 invoked by alias); 31 Jan 2007 19:33:27 -0000 Received: (qmail 31251 invoked by uid 22791); 31 Jan 2007 19:33:26 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 31 Jan 2007 19:33:21 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1HCLCQ-0001yI-B2; Wed, 31 Jan 2007 14:32:54 -0500 Date: Wed, 31 Jan 2007 19:33:00 -0000 From: Daniel Jacobowitz To: Denis PILAT Cc: gdb-patches Subject: Re: [RFC] thread apply commands change selected frame Message-ID: <20070131193254.GA7389@nevyn.them.org> Mail-Followup-To: Denis PILAT , gdb-patches References: <45A61E73.8030400@st.com> <20070121173341.GG12463@nevyn.them.org> <45B73813.9060005@st.com> <45C05A1A.6010109@st.com> <20070131145407.GA24233@nevyn.them.org> <45C0BC7E.80409@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45C0BC7E.80409@st.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00624.txt.bz2 On Wed, Jan 31, 2007 at 04:57:50PM +0100, Denis PILAT wrote: > Your remarks have been taken into account into the attached patch. > Are you ok for committing this one plus the previous patch regarding the > thread.c ? > (Frederic Riss will do that for me) Yes, that's OK (with a minor fix, below). Let me know if you would like write access yourself. > +gdb_test "thread apply all print 1" "Thread ..*\\\$7 = 1.*Thread ..*\\\$8 = 1.*Thread ..*\\\$9 = 1.*Thread ..*\\\$10 = 1.*Thread ..*\\\$11 = 1.*Thread ..*\\\$12 = 1" "run a simple print command on all thread" Checking for $[specific number] should be avoided, because adding more tests earlier in the file will break it. Use \\\$\[0-9]+ instead. -- Daniel Jacobowitz CodeSourcery