From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20632 invoked by alias); 31 Jan 2007 14:54:17 -0000 Received: (qmail 20619 invoked by uid 22791); 31 Jan 2007 14:54:16 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 31 Jan 2007 14:54:11 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1HCGqd-0006N3-Ff; Wed, 31 Jan 2007 09:54:07 -0500 Date: Wed, 31 Jan 2007 14:54:00 -0000 From: Daniel Jacobowitz To: Denis PILAT Cc: gdb-patches Subject: Re: [RFC] thread apply commands change selected frame Message-ID: <20070131145407.GA24233@nevyn.them.org> Mail-Followup-To: Denis PILAT , gdb-patches References: <45A61E73.8030400@st.com> <20070121173341.GG12463@nevyn.them.org> <45B73813.9060005@st.com> <45C05A1A.6010109@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45C05A1A.6010109@st.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00608.txt.bz2 On Wed, Jan 31, 2007 at 09:58:02AM +0100, Denis PILAT wrote: > I propose a new implementation that does not change the old behavior of > gdb with respect to the printing of the last frame in case we changed of > thread during "thread apply" command execution. > > This implementation does not make any regression in the testsuite for a > i386-linux target. > To me the part that prints the stack frame at the end of execution of > "thread apply" could be entirely removed but this will imply some > changes in the testsuite. I can do that it's up to you. Thanks. I don't have any opinion on this - for now, let's just leave it the way it was. > +# Go into the thread_function to check that a simple "thread apply" > +# does not change the selected frame. > +gdb_test "step" "thread_function.*" > +gdb_test "up" > +gdb_test "thread apply all print 1" > +gdb_test "down" "#0.*thread_function.*" "Thread apply must not change the selected frame" The default name for a test is the command, if you don't specify a name. These are pretty generic commands, but test names are supposed to be unique within a .exp file. I would recommend giving them names (and probably checking their output, at least a little, too...). -- Daniel Jacobowitz CodeSourcery