From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13987 invoked by alias); 25 Jan 2007 23:27:50 -0000 Received: (qmail 13978 invoked by uid 22791); 25 Jan 2007 23:27:49 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 25 Jan 2007 23:27:37 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1HAE0B-0007rF-3h; Thu, 25 Jan 2007 18:27:31 -0500 Date: Thu, 25 Jan 2007 23:27:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Denis PILAT , gdb-patches Subject: Re: [RFC] varobj deletion after the binary has changed Message-ID: <20070125232731.GA30178@nevyn.them.org> Mail-Followup-To: Nick Roberts , Denis PILAT , gdb-patches References: <45B60056.6030704@st.com> <20070123124457.GA1600@nevyn.them.org> <45B63A49.4010609@st.com> <45B8E8A8.9040904@st.com> <17849.12231.246980.478169@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17849.12231.246980.478169@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00526.txt.bz2 I haven't looked at the patch yet, just Nick's comments, which I generally agree with :-) On Fri, Jan 26, 2007 at 11:31:35AM +1300, Nick Roberts wrote: > Is xstrdup just a simpler version of savestring? i.e. > > tmp_var->obj_name = xstrdup (*varp)->obj_name); Yes - savestring is handy for saving only part of a string but xstrdup is clearer. -- Daniel Jacobowitz CodeSourcery