From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [rfc] Plug memory leaks during gdbarch initialization
Date: Tue, 23 Jan 2007 17:17:00 -0000 [thread overview]
Message-ID: <20070123171703.GA18534@nevyn.them.org> (raw)
In-Reply-To: <m3irexvk8i.fsf@codesourcery.com>
On Tue, Jan 23, 2007 at 07:25:01AM -0800, Jim Blandy wrote:
>
> Daniel Jacobowitz <drow@false.org> writes:
> > The patch is an improvement, but doesn't fix that wart. I don't really
> > want to check it in without fixing the underlying problem but I don't
> > see a good way... anyone have a suggestion?
>
> I could imagine having each file's _initialize function start with:
Now that they're in deprecated_register_gdbarch_swap, this isn't enough
- we no longer rely on _initialize_foo's order directly, but indirectly
through the order of initializer functions in the swap list.
Hmm, but your change would still fix it, with judicious addition of
comments that order matters for swaps...
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2007-01-23 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 14:45 Daniel Jacobowitz
2007-01-23 15:25 ` Jim Blandy
2007-01-23 17:17 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070123171703.GA18534@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox