From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6736 invoked by alias); 21 Jan 2007 22:56:17 -0000 Received: (qmail 6728 invoked by uid 22791); 21 Jan 2007 22:56:17 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sun, 21 Jan 2007 22:56:12 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H8lbe-0007lu-2X; Sun, 21 Jan 2007 17:56:10 -0500 Date: Sun, 21 Jan 2007 22:56:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Follow specific symbol's DW_AT_decl_file Message-ID: <20070121225610.GB29708@nevyn.them.org> Mail-Followup-To: Jan Kratochvil , gdb-patches@sourceware.org References: <20070111223940.GA8958@host0.dyn.jankratochvil.net> <20070121165451.GA12463@nevyn.them.org> <20070121223533.GA1890@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070121223533.GA1890@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00450.txt.bz2 On Sun, Jan 21, 2007 at 11:35:33PM +0100, Jan Kratochvil wrote: > On Sun, 21 Jan 2007 17:54:51 +0100, Daniel Jacobowitz wrote: > ... > > /* This structure is space critical. See space comments at the top. */ > > > > So I wrote an implementation that used an on-the-side hash table. But > > in the end, it was a bit slower, and most symbols needed one. Even > > with -readnow the memory increase was only 3%, so it will be less than > > that in practice. So I went back to doing it in the symbol after all > > :-) > > Due to that comment I originally valgrind(1)ed it and on my testcase the memory > requirement increase was visible but negligible. How did you use valgrind for this - massif? I hadn't tried that one before. I used an old copy of glibc's memusage script; massif is a bit more interesting. -- Daniel Jacobowitz CodeSourcery