From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3094 invoked by alias); 21 Jan 2007 15:59:50 -0000 Received: (qmail 3046 invoked by uid 22791); 21 Jan 2007 15:59:48 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sun, 21 Jan 2007 15:59:44 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H8f6b-0002WJ-LP; Sun, 21 Jan 2007 10:59:41 -0500 Date: Sun, 21 Jan 2007 15:59:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org, hongjiu.lu@intel.com Subject: Re: PATCH: Initialize tmp_obstack Message-ID: <20070121155940.GA9459@nevyn.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org, hongjiu.lu@intel.com References: <20061205204003.GB25572@nevyn.them.org> <12601.163.1.150.229.1165354805.squirrel@webmail.xs4all.nl> <20061205214306.GA29801@nevyn.them.org> <20637.163.1.150.229.1165355320.squirrel@webmail.xs4all.nl> <20061205215639.GA30371@nevyn.them.org> <20061205235848.GA2551@nevyn.them.org> <20061207144018.GA12915@nevyn.them.org> <20061225040032.GA29719@nevyn.them.org> <20070116065937.GA15794@nevyn.them.org> <200701211307.l0LD7EO0000187@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200701211307.l0LD7EO0000187@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00433.txt.bz2 On Sun, Jan 21, 2007 at 02:07:14PM +0100, Mark Kettenis wrote: > I had another look and come up with the attached. By always > initializing tmp_obstack the code is less optimal, but at least I can > convince myself the code is safe now. Unfortunately I can't test > whether this fixes the GCC 4.1 warnings. Thanks! I can test it - I'll let you know this afternoon. p-valprint.c has the same problem, but the correct fix there is going to be to delete some code. Pascal copied a lot from C/C++ but it doesn't actually have static members to the best of my knowledge. I see some discussion of them as planned for GNU Pascal, but no implementations. -- Daniel Jacobowitz CodeSourcery