From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24243 invoked by alias); 20 Jan 2007 20:34:47 -0000 Received: (qmail 24235 invoked by uid 22791); 20 Jan 2007 20:34:47 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 20 Jan 2007 20:34:41 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H8Mv9-0007F4-Bf; Sat, 20 Jan 2007 15:34:39 -0500 Date: Sat, 20 Jan 2007 20:34:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix bug in set substitute-patch Message-ID: <20070120203439.GA27823@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20070112040310.GI537@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070112040310.GI537@adacore.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00427.txt.bz2 On Fri, Jan 12, 2007 at 08:03:10AM +0400, Joel Brobecker wrote: > This should fix a bug reported by Daniel when the source file is > compiled using absolute filenames. > > % gcc -c -o foo /path/to/foo.c > > As Daniel reported, what happens in this case is that the compiler > puts the filename full path into the filename, and then leaves the > dirname empty. > > 2007-01-12 Joel Brobecker > > * source.c (find_and_open_source): Try rewriting the source > path inside filename if dirname is NULL. > > Tested on x86-linux, no regression. > OK to apply? OK, and thanks. -- Daniel Jacobowitz CodeSourcery