From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3047 invoked by alias); 20 Jan 2007 19:45:59 -0000 Received: (qmail 3039 invoked by uid 22791); 20 Jan 2007 19:45:59 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 20 Jan 2007 19:45:52 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H8M9s-0006eO-Lj; Sat, 20 Jan 2007 14:45:48 -0500 Date: Sat, 20 Jan 2007 19:45:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [mi] fix 'editable' attribute for references Message-ID: <20070120194548.GD22153@nevyn.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200701162138.39578.ghost@cs.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00422.txt.bz2 On Tue, Jan 16, 2007 at 10:06:30PM +0300, Vladimir Prus wrote: > Vladimir Prus wrote: > > > > > I've noticed that the -var-show-references returns 'attr=noneditable' for > > structures, but 'attr=editable' for references to structures, which makes > > no sense. > > I've also noticed that while for structures, we don't compare old > and new values, and never report varobj corresponding to structure as > changed, we do all that for references to structures. This patch fixes > both problems, OK? This is included in the C++ references patch I just reviewed, right? -- Daniel Jacobowitz CodeSourcery