From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26678 invoked by alias); 20 Jan 2007 19:09:11 -0000 Received: (qmail 26668 invoked by uid 22791); 20 Jan 2007 19:09:11 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 20 Jan 2007 19:09:06 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H8LaJ-0006AK-Ek; Sat, 20 Jan 2007 14:09:03 -0500 Date: Sat, 20 Jan 2007 19:09:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] MI: Add value field to output of -var-create Message-ID: <20070120190903.GA22153@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17818.12006.696879.216415@kahikatea.snap.net.nz> <20070105150747.GD24554@nevyn.them.org> <17839.14615.772612.987502@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17839.14615.772612.987502@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00420.txt.bz2 On Thu, Jan 18, 2007 at 10:08:39PM +1300, Nick Roberts wrote: Content-Description: message body and .signature > > > This patch just adds the value field to the output of var-create so that > > > the frontend doesn't need to issue another command to find out what it > > > is. > > > > > > If approved, I'll change the tests and documentation accordingly. > > > > Seems fine to me, after we work out what to do with the testsuite. I > > went to check whether this should be PRINT_ALL_VALUES or > > PRINT_SIMPLE_VALUES but it seems fine the way you've got it - I wish > > I could remember the rational for PRINT_SIMPLE_VALUES properly. > > OK, I've done this now with all tests changed. I've used Vladimir's > mi_create_varobj as much as possible. The three places where I've kept > -var-create are: > > 1) Where failure of -var-create is being tested. > 2) Where a command token is used. > 3) Where a name isn't specified for the variable object ("-" used). > > I get the same test results before and after my change. Thanks for doing this. I get some new failures - just three though. FAIL: gdb.mi/gdb701.exp: create fooPtr FAIL: gdb.mi/gdb792.exp: create var for class A FAIL: gdb.mi/gdb792.exp: create var for class C which has baseclass A # Why does this have a FIXME? setup_xfail *-*-* mi_gdb_test "-var-update *" \ ! "FIXME\\^done,changelist=\\\[\{name=\"psnp->ptrs.0.next.long_ptr\",in_scope=\pe_changed=\"false\"\}\\\]" \ "update all vars psnp->next->long_ptr (and 1.long_ptr) changed" clear_xfail *-*-* Typo, I think ("in_scope=\pe_changed")? -- Daniel Jacobowitz CodeSourcery