From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: drow@false.org
Cc: gdb-patches@sourceware.org, hongjiu.lu@intel.com
Subject: Re: PATCH: Initialize tmp_obstack
Date: Tue, 16 Jan 2007 21:32:00 -0000 [thread overview]
Message-ID: <200701162131.l0GLVhER027793@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20070116065937.GA15794@nevyn.them.org> (message from Daniel Jacobowitz on Tue, 16 Jan 2007 01:59:38 -0500)
> Date: Tue, 16 Jan 2007 01:59:38 -0500
> From: Daniel Jacobowitz <drow@false.org>
>
> On Sun, Dec 24, 2006 at 11:00:32PM -0500, Daniel Jacobowitz wrote:
> > On Thu, Dec 07, 2006 at 09:40:18AM -0500, Daniel Jacobowitz wrote:
> > > On Tue, Dec 05, 2006 at 06:58:48PM -0500, Daniel Jacobowitz wrote:
> > > > Since there's disagreement about this patch, I have reverted it. We
> > > > can put it back in when there's consensus.
> > >
> > > Unfortunately, when I reverted it the discussion stopped dead without
> > > advancing towards consensus.
> > >
> > > What do we do about this warning?
> >
> > No one has replied. While I agree that GCC is not being very helpful
> > here, I don't anticipate a reliable compiler fix, and it's really
> > beginning to frustrate me that I can't use -Werror on my laptop
> > (I'm travelling).
> >
> > Mark, how strongly do you object to HJ's workaround? If it's
> > unacceptable, will you volunteer to simplify the affected functions
> > to avoid the warning?
>
> I'm travelling again - excuse spotty response this week, please. But
> that means I'm hacking on GDB on my laptop again, which is affected by
> this problem.
>
> How can we avoid the uninitialized warnings?
I've looked at the code, I couldn't see an easy way. I couldn't find
an easy way because the code is actually very hard to understand. I
really think the code should be rewritten such that it is easier to
understand.
Mark
next prev parent reply other threads:[~2007-01-16 21:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-02 18:27 H. J. Lu
2006-12-05 20:40 ` Daniel Jacobowitz
2006-12-05 20:56 ` H. J. Lu
2006-12-05 21:00 ` Daniel Jacobowitz
[not found] ` <12601.163.1.150.229.1165354805.squirrel@webmail.xs4all.nl>
[not found] ` <20061205214306.GA29801@nevyn.them.org>
[not found] ` <20637.163.1.150.229.1165355320.squirrel@webmail.xs4all.nl>
2006-12-05 21:56 ` Daniel Jacobowitz
2006-12-05 21:59 ` Daniel Jacobowitz
2006-12-05 22:24 ` Jim Blandy
2006-12-05 23:58 ` Daniel Jacobowitz
2006-12-07 14:40 ` Daniel Jacobowitz
2006-12-25 4:00 ` Daniel Jacobowitz
2007-01-16 6:59 ` Daniel Jacobowitz
2007-01-16 21:32 ` Mark Kettenis [this message]
2007-01-21 13:07 ` Mark Kettenis
2007-01-21 15:59 ` Daniel Jacobowitz
2007-01-21 17:24 ` Daniel Jacobowitz
2007-02-08 14:21 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701162131.l0GLVhER027793@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=hongjiu.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox