From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-47217-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22296 invoked by alias); 16 Jan 2007 21:28:15 -0000
Received: (qmail 22248 invoked by uid 22791); 16 Jan 2007 21:28:14 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 16 Jan 2007 21:28:08 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.13.8/8.13.8) with ESMTP id l0GLS27p027976; 	Tue, 16 Jan 2007 22:28:02 +0100 (CET)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.13.8/8.13.8/Submit) id l0GLS1U4024821; 	Tue, 16 Jan 2007 22:28:01 +0100 (CET)
Date: Tue, 16 Jan 2007 21:28:00 -0000
Message-Id: <200701162128.l0GLS1U4024821@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: deuling@de.ibm.com
CC: gdb-patches@sourceware.org
In-reply-to: <45AC7532.6010108@de.ibm.com> (message from Markus Deuling on 	Tue, 16 Jan 2007 07:48:18 +0100)
Subject: Re: [RFA]: gdb/testsuite/gdb.arch/altivec-regs.exp Broken testcase
References:  <45AC7532.6010108@de.ibm.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-01/txt/msg00366.txt.bz2

> Date: Tue, 16 Jan 2007 07:48:18 +0100
> From: Markus Deuling <deuling@de.ibm.com>
> 
> Hi,
> 
> I'm referring to http://sourceware.org/ml/gdb-patches/2007-01/msg00353.html.
> 
> It seems that the output from "show endian" has changed since the last time someone took a 
> look into it :-) So I added a "re" to the test.
> 
> Do we need this branch or can I delete it ?
> >>     -re "(The target endianness is set automatically .currently )(big|little)( endian.*)$gdb_prompt $" {
> >>         pass "endianness"
> >>        set endianness $expect_out(2,string)
> >>     }

This worries me a bit.  So in the past we were able to determine the
endianness automagically, but now we don't?  Do we understand why?
Doesn't this mean that something is broken that worked before?

> This is the result of gdb.arch/altivec-regs.exp with my patch:
> 
> # of expected passes            209
> # of unexpected failures        1
> 
> 
> Is it ok to apply ?
> 
> ChangeLog:
> 
>        *gdb.arch/altivec-regs.exp: Initialise variable
>        endianness in every case. 
> 
> ==========================================
> diff -urN dev/gdb/testsuite/gdb.arch/altivec-regs.exp src/gdb/testsuite/gdb.arch/altivec-regs.exp
> --- dev/gdb/testsuite/gdb.arch/altivec-regs.exp 2007-01-10 15:48:12.000000000 +0100
> +++ src/gdb/testsuite/gdb.arch/altivec-regs.exp 2007-01-16 07:40:05.000000000 +0100
> @@ -88,12 +88,17 @@
> 
>  gdb_test "next" "" ""
> 
> +set endianness ""
>  send_gdb "show endian\n"
>  gdb_expect {
>      -re "(The target endianness is set automatically .currently )(big|little)( endian.*)$gdb_prompt $" {
>          pass "endianness"
>         set endianness $expect_out(2,string)
>      }
> +    -re "The target is assumed to be big endian.*" {
> +        pass "endianess"
> +        set endianness "big"
> +    }
>      -re ".*$gdb_prompt $" {
>         fail "couldn't get endianness"
>      }