From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: nickrob@snap.net.nz
Cc: ghost@cs.msu.su, gdb-patches@sources.redhat.com
Subject: Re: MI failures related to string printing
Date: Tue, 16 Jan 2007 21:23:00 -0000 [thread overview]
Message-ID: <200701162123.l0GLN5kF029500@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <17836.26533.146945.793792@kahikatea.snap.net.nz> (message from Nick Roberts on Tue, 16 Jan 2007 18:50:29 +1300)
> From: Nick Roberts <nickrob@snap.net.nz>
> Date: Tue, 16 Jan 2007 18:50:29 +1300
>
> > Is there any chance you'll robustify the testsuite?
>
> If your just talking about the one FAIL in mi-var-child.exp, why not
> just mark it as an XFAIL? I see that the other XFAIL actually
> passes (for me, at least).
The very fact that we're even having this discussion means that you
did something wrong Nick; you either didn't check for regressions or
ignored them.
Turning a regression test from a PASS into a FAIL, means you've
changed behaviour. Now that change could be intentional, but then you
should have said so when you submitted the patch, and you should have
adjusted the test.
I'm still not convinced the change is ok. Having 'char *' point to a
buffer that's not null-terminated is not uncommon. We have a lot of
those in gdb itself.
Mark
next prev parent reply other threads:[~2007-01-16 21:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200701121351.29310.vladimir@codesourcery.com>
[not found] ` <17831.31430.442855.801431@kahikatea.snap.net.nz>
2007-01-16 2:08 ` Vladimir Prus
2007-01-16 5:50 ` Nick Roberts
2007-01-16 6:42 ` Vladimir Prus
2007-01-16 20:44 ` Nick Roberts
2007-01-16 23:06 ` Vladimir Prus
2007-01-17 0:59 ` Nick Roberts
2007-01-17 6:01 ` Daniel Jacobowitz
2007-01-17 8:12 ` Nick Roberts
2007-01-16 21:23 ` Mark Kettenis [this message]
2007-01-16 22:16 ` Nick Roberts
2007-01-17 6:06 ` Daniel Jacobowitz
2007-01-17 21:44 ` Mark Kettenis
2007-01-17 22:19 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701162123.l0GLN5kF029500@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox