From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: uweigand@de.ibm.de
Cc: gdb-patches@sourceware.org
Subject: [RFA] Fix {get|put}_frame_register_bytes
Date: Sat, 13 Jan 2007 17:31:00 -0000 [thread overview]
Message-ID: <200701131731.l0DHV9cV031712@brahms.sibelius.xs4all.nl> (raw)
Hi Ulrich,
Looks like there's a bug in the new get_frame_register_bytes() and
put_frame_register_bytes(). I suppose the patch below is what you
intended.
Caught on OpenBSD/powerpc.
ok?
Mark
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* frame.c (get_frame_register_bytes, put_frame_register_bytes):
Don't forget to move destination pointer.
Index: frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.219
diff -u -p -r1.219 frame.c
--- frame.c 11 Jan 2007 17:18:22 -0000 1.219
+++ frame.c 13 Jan 2007 17:28:47 -0000
@@ -775,6 +775,7 @@ get_frame_register_bytes (struct frame_i
memcpy (myaddr, buf + offset, curr_len);
}
+ myaddr += curr_len;
len -= curr_len;
offset = 0;
regnum++;
@@ -815,6 +816,7 @@ put_frame_register_bytes (struct frame_i
put_frame_register (frame, regnum, buf);
}
+ myaddr += curr_len;
len -= curr_len;
offset = 0;
regnum++;
next reply other threads:[~2007-01-13 17:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-13 17:31 Mark Kettenis [this message]
2007-01-13 18:26 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701131731.l0DHV9cV031712@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox