From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11616 invoked by alias); 13 Jan 2007 14:02:43 -0000 Received: (qmail 11594 invoked by uid 22791); 13 Jan 2007 14:02:42 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 13 Jan 2007 14:02:32 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id 117D548CEB1; Sat, 13 Jan 2007 09:02:31 -0500 (EST) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 01125-01-5; Sat, 13 Jan 2007 09:02:30 -0500 (EST) Received: from takamaka.act-europe.fr (AStDenis-105-1-89-113.w80-8.abo.wanadoo.fr [80.8.218.113]) by nile.gnat.com (Postfix) with ESMTP id 246B048CBF1; Sat, 13 Jan 2007 09:02:30 -0500 (EST) Received: by takamaka.act-europe.fr (Postfix, from userid 1000) id 21A5034C099; Sat, 13 Jan 2007 18:03:20 +0400 (RET) Date: Sat, 13 Jan 2007 14:02:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Improve help set/unset/show substitute-path Message-ID: <20070113140320.GL537@adacore.com> References: <20070112071323.GJ537@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="gE7i1rD7pdK0Ng3j" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00329.txt.bz2 --gE7i1rD7pdK0Ng3j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 327 Thanks for the feedback, Eli. With your help, I think this second version is a huge improvement. 2007-01-13 Joel Brobecker * source.c (_initialize_source): Improve the help text of the substitute-path commands. Tested on x86-linux, no regression. OK to commit? Thank you, -- Joel --gE7i1rD7pdK0Ng3j Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="help.diff" Content-length: 1616 Index: source.c =================================================================== RCS file: /cvs/src/src/gdb/source.c,v retrieving revision 1.77 diff -u -p -r1.77 source.c --- source.c 9 Jan 2007 17:58:58 -0000 1.77 +++ source.c 13 Jan 2007 14:00:42 -0000 @@ -1997,16 +1997,24 @@ Show number of source lines gdb will lis add_cmd ("substitute-path", class_files, set_substitute_path_command, _("\ -Add a source path substitution rule. If a substitution rule was previously\n\ -set, it is overridden."), &setlist); +Usage: set substitute-path FROM TO\n\ +Add a substitution rule replacing FROM into TO in source file names.\n\ +If a substitution rule was previously set for FROM, the old rule\n\ +is replaced by the new one."), + &setlist); add_cmd ("substitute-path", class_files, unset_substitute_path_command, _("\ -Remove the current source path substitution rule. This has no effect\n\ -if no path substitution rule was previously specified."), +Usage: unset substitute-path [FROM]\n\ +Delete the rule for substituting FROM in source file names. If FROM\n\ +is not specified, all substituting rules are deleted.\n\ +If the debugger cannot find a rule for FROM, it will display a warning."), &unsetlist); add_cmd ("substitute-path", class_files, show_substitute_path_command, - _("Show the current source path substitution rule."), + _("\ +Usage: show substitute-path [FROM]\n\ +Print the rule for substituting FROM in source file names. If FROM\n\ +is not specified, print all substitution rules."), &showlist); } --gE7i1rD7pdK0Ng3j--