From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9039 invoked by alias); 11 Jan 2007 20:02:31 -0000 Received: (qmail 9030 invoked by uid 22791); 11 Jan 2007 20:02:30 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 11 Jan 2007 20:02:26 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H5680-000763-Ea; Thu, 11 Jan 2007 15:02:24 -0500 Date: Thu, 11 Jan 2007 20:02:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] DW_CFA_GNU_negative_offset_extended support Message-ID: <20070111200224.GA27260@nevyn.them.org> Mail-Followup-To: Jan Kratochvil , gdb-patches@sourceware.org References: <20061230190615.GA22829@host0.dyn.jankratochvil.net> <20070103182742.GD17935@nevyn.them.org> <20070111191107.GA4993@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070111191107.GA4993@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00306.txt.bz2 On Thu, Jan 11, 2007 at 08:11:07PM +0100, Jan Kratochvil wrote: > the patch is updated according to your advices. Thanks. It may be a week or two before I have a chance to do patch review again, unfortunately, but when I do I'll take care of this (if no one gets there first). > > Please use gdb_run_cmd instead. See other tests for an example. > > ("run" doesn't work for remote targets.) > > Fixed. Copying other code just is not enough for GDB... Yeah - some of the testsuite needs work, but it's low reward for the effort when we could be fixing GDB instead. -- Daniel Jacobowitz CodeSourcery