From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24259 invoked by alias); 9 Jan 2007 20:58:50 -0000 Received: (qmail 14123 invoked by uid 22791); 9 Jan 2007 20:56:27 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 09 Jan 2007 20:56:16 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1H4O0t-0006X3-R7 for gdb-patches@sources.redhat.com; Tue, 09 Jan 2007 23:56:13 +0300 Received: from localhost ([127.0.0.1] helo=ip6-localhost) by zigzag.lvk.cs.msu.su with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1H4O0t-0006Wx-JU for gdb-patches@sources.redhat.com; Tue, 09 Jan 2007 23:56:07 +0300 From: Vladimir Prus To: gdb-patches@sources.redhat.com Subject: Robustify mi-var-cp Date: Tue, 09 Jan 2007 20:58:00 -0000 User-Agent: KMail/1.9.1 MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_5EApFEf8CV9s+ju" Message-Id: <200701092355.21537.ghost@cs.msu.su> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00265.txt.bz2 --Boundary-00=_5EApFEf8CV9s+ju Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 175 This test fails for me, apparently due to compiler version dependency. The attached patch makes sure we don't try to access variables that are out of scope. OK? - Volodya --Boundary-00=_5EApFEf8CV9s+ju Content-Type: text/x-diff; charset="us-ascii"; name="mi-var-cp.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="mi-var-cp.diff" Content-length: 1075 Index: mi-var-cp.cc =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-var-cp.cc,v retrieving revision 1.5 diff -u -p -r1.5 mi-var-cp.cc --- mi-var-cp.cc 9 Jan 2007 17:59:13 -0000 1.5 +++ mi-var-cp.cc 9 Jan 2007 20:54:23 -0000 @@ -31,6 +31,8 @@ void reference_update_tests () x = 567; /*: mi_varobj_update RX {} "update RX (3)" :*/ + /* Dummy assignment to keep 'x' in scope. */ + x = 444; /*: END: reference_update :*/ } @@ -72,12 +74,11 @@ void base_in_reference_test_main () int reference_to_pointer () { + /*: BEGIN: reference_to_pointer :*/ S s, *ptr_s, *& rptr_s = ptr_s; s.i = 67; s.j = 89; ptr_s = &s; - /*: BEGIN: reference_to_pointer :*/ - return 99; /*: mi_create_varobj RPTR rptr_s "create varobj for rptr_s" @@ -91,6 +92,7 @@ int reference_to_pointer () mi_check_varobj_value RPTR.public.i 67 "check i member" mi_check_varobj_value RPTR.public.j 89 "check j member" :*/ + return 99; /*: END: reference_to_pointer :*/ } --Boundary-00=_5EApFEf8CV9s+ju--