From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2048 invoked by alias); 9 Jan 2007 21:45:26 -0000 Received: (qmail 2037 invoked by uid 22791); 9 Jan 2007 21:45:25 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 09 Jan 2007 21:45:18 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H4OmQ-0001C4-Ky; Tue, 09 Jan 2007 16:45:14 -0500 Date: Tue, 09 Jan 2007 21:45:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: Fix 'selected frame' varobjs Message-ID: <20070109214514.GF30631@nevyn.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200612310301.42649.ghost@cs.msu.su> <20061231214221.GB26604@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00270.txt.bz2 On Wed, Jan 10, 2007 at 12:20:55AM +0300, Vladimir Prus wrote: > What about the attached? > > - Volodya > > 2006-12-31 Daniel Jacobowitz > Vladimir Prus > > Fix 'selected frame' varobjs. > * varobj.c (struct varobj): Remove the error field. > (varobj_set_value): Don't check var->error. > (install_new_value): Don't set var->error. > (varobj_update): Always pass the new value > of the root via install_new_value. > (create_child): Don't set error field. > (new_variable): Likewise. > (c_value_of_root): Always reevaluate the value > of selected frame varobjs in the selected frame. > Don't call reinit_frame_cache. Looks good to me - this is OK. -- Daniel Jacobowitz CodeSourcery